Skip to content

BUG: astype_view check raising on minimum versions build #51974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 15, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Mar 14, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

This code path was never hit on the min versions build. Stumbled upon this on another pr

@phofl phofl added the Dtype Conversions Unexpected or buggy dtype conversions label Mar 14, 2023
@phofl phofl added this to the 2.0 milestone Mar 14, 2023
@phofl
Copy link
Member Author

phofl commented Mar 15, 2023

I'll merge this to get into the rc

@phofl phofl merged commit 880f63b into pandas-dev:main Mar 15, 2023
@phofl phofl deleted the cow_astype_min_versions branch March 15, 2023 10:25
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Mar 15, 2023
phofl added a commit that referenced this pull request Mar 15, 2023
… minimum versions build) (#51983)

Backport PR #51974: BUG: astype_view check raising on minimum versions build

Co-authored-by: Patrick Hoefler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dtype Conversions Unexpected or buggy dtype conversions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant